Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PyPy version in documentation #5678

Merged
merged 2 commits into from Oct 12, 2022
Merged

Update PyPy version in documentation #5678

merged 2 commits into from Oct 12, 2022

Conversation

Laerte
Copy link
Member

@Laerte Laerte commented Oct 11, 2022

The first one i bumped to match the same version of pypy3.7, after this PR was merged:

I was in doubt about what version to use in second statement but both pypy3.7 and pypy3.9 use the same version, maybe we could remove this paragraph altogether since now is redundant? Version 5.9.0 is from 2017-10-05.

@codecov
Copy link

codecov bot commented Oct 11, 2022

Codecov Report

Merging #5678 (c99e416) into master (e4f6545) will increase coverage by 0.14%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #5678      +/-   ##
==========================================
+ Coverage   88.69%   88.83%   +0.14%     
==========================================
  Files         162      162              
  Lines       10967    10967              
  Branches     1797     1797              
==========================================
+ Hits         9727     9743      +16     
+ Misses        960      943      -17     
- Partials      280      281       +1     
Impacted Files Coverage Δ
scrapy/core/downloader/__init__.py 90.97% <0.00%> (-1.51%) ⬇️
scrapy/robotstxt.py 97.53% <0.00%> (+22.22%) ⬆️

@wRAR
Copy link
Member

wRAR commented Oct 12, 2022

I don't really know what should we do with these versions, we don't explicitly set them in the CI, so the versions in the docs can easily become outdated again.

Copy link
Member

@Gallaecio Gallaecio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, now that we do not explicitly test them maybe we could simply remove the mentions of specific PyPy versions from the docs.

@Laerte
Copy link
Member Author

Laerte commented Oct 12, 2022

@wRAR @Gallaecio Yeah i was in doubt about this too, but i totally agree with you guys, i push new commit to remove these mentions of specific PyPy versions.

@Laerte Laerte requested a review from Gallaecio October 12, 2022 12:07
@Gallaecio Gallaecio merged commit da9a2f8 into scrapy:master Oct 12, 2022
@Gallaecio
Copy link
Member

Thanks!

@Laerte Laerte deleted the docs/pypy-version branch October 12, 2022 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants