Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated ubuntu workflow image to latest stable image #5675

Merged
merged 1 commit into from Oct 14, 2022

Conversation

Nirzak
Copy link
Contributor

@Nirzak Nirzak commented Oct 10, 2022

Updated ubuntu workflow image latest ubuntu stable image as Ubuntu 18.04 is a bit old and will soon meet its end-of-life support.

Resolves #5671

@Nirzak
Copy link
Contributor Author

Nirzak commented Oct 10, 2022

This PR will close #5671

@codecov
Copy link

codecov bot commented Oct 10, 2022

Codecov Report

Merging #5675 (7002727) into master (f36d054) will increase coverage by 0.16%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #5675      +/-   ##
==========================================
+ Coverage   88.69%   88.85%   +0.16%     
==========================================
  Files         162      162              
  Lines       10967    10967              
  Branches     1797     1797              
==========================================
+ Hits         9727     9745      +18     
+ Misses        960      942      -18     
  Partials      280      280              
Impacted Files Coverage Δ
scrapy/robotstxt.py 97.53% <0.00%> (+22.22%) ⬆️

@elacuesta elacuesta linked an issue Oct 10, 2022 that may be closed by this pull request
@Laerte
Copy link
Member

Laerte commented Oct 14, 2022

We don't have much choice now, since they deprecated 18.04 without notice, so no CI will run on 18.04.

@Gallaecio
Copy link
Member

Merging despite #5671 (comment) given the sudden unavailability.

@Gallaecio Gallaecio merged commit 22a59d0 into scrapy:master Oct 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Updating workflow to use Ubuntu Latest Image
4 participants