2.6.3 #5637
Merged
2.6.3 #5637
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gábor Lipták <gliptak@gmail.com>
|
Should we backport #5632 as well? |
Signed-off-by: Gábor Lipták <gliptak@gmail.com>
Codecov Report
@@ Coverage Diff @@
## 2.6 #5637 +/- ##
==========================================
- Coverage 88.80% 88.67% -0.13%
==========================================
Files 163 163
Lines 10679 10678 -1
Branches 1825 1825
==========================================
- Hits 9483 9469 -14
- Misses 919 932 +13
Partials 277 277
|
|
Do failing tests mean #5617 needs to be ported as well? |
|
I think so, and I think it may not be the only one. |
Fix failed tests related to w3lib
|
#5639 seems to be the only remaining issue. |
Merged
kmike
approved these changes
Sep 27, 2022
|
A Scrapy patch release coming up… |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.