Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update test-standard link in contributing docs #5631

Merged
merged 2 commits into from Sep 20, 2022
Merged

Update test-standard link in contributing docs #5631

merged 2 commits into from Sep 20, 2022

Conversation

gliptak
Copy link
Contributor

@gliptak gliptak commented Sep 17, 2022

correcting

arning, treated as error:
/home/runner/work/scrapy/scrapy/docs/contributing.rst:216:unknown document: twisted:core/development/policy/test-standard
ERROR: InvocationError for command /home/runner/work/scrapy/scrapy/.tox/docs/bin/sphinx-build -W -b html . /home/runner/work/scrapy/scrapy/.tox/docs/tmp/html (exited with code 2)
___________________________________ summary ____________________________________
ERROR:   docs: commands failed

@codecov
Copy link

codecov bot commented Sep 18, 2022

Codecov Report

Merging #5631 (0222227) into master (681d114) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #5631   +/-   ##
=======================================
  Coverage   88.66%   88.66%           
=======================================
  Files         162      162           
  Lines       10965    10965           
  Branches     1894     1894           
=======================================
  Hits         9722     9722           
  Misses        963      963           
  Partials      280      280           

@wRAR
Copy link
Member

wRAR commented Sep 19, 2022

The test now says

/home/runner/work/scrapy/scrapy/docs/contributing.rst:216:unknown document: twisted:core/development/test-standard

@gliptak
Copy link
Contributor Author

gliptak commented Sep 19, 2022

@wRAR this seem to be the page available https://docs.twisted.org/en/stable/development/test-standard.html

maybe cross linkage works differently

@Gallaecio
Copy link
Member

I think we may need to remove core/ as well.

@gliptak
Copy link
Contributor Author

gliptak commented Sep 20, 2022

Thanks @Gallaecio updated

@Gallaecio Gallaecio merged commit 1429aa0 into scrapy:master Sep 20, 2022
@Gallaecio
Copy link
Member

Thanks!

@gliptak gliptak deleted the patch-2 branch September 20, 2022 21:45
Gallaecio pushed a commit to Gallaecio/scrapy that referenced this pull request Sep 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants