Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failed tests related to w3lib #5617

Merged
merged 3 commits into from Sep 7, 2022
Merged

Fix failed tests related to w3lib #5617

merged 3 commits into from Sep 7, 2022

Conversation

Laerte
Copy link
Member

@Laerte Laerte commented Sep 6, 2022

This fix failed tests from this issue: #5612

- tox.wiki is offline that's why checks is failing (tox-dev/tox#2486)

@codecov
Copy link

codecov bot commented Sep 6, 2022

Codecov Report

Merging #5617 (6186e82) into master (52d9349) will not change coverage.
The diff coverage is n/a.

❗ Current head 6186e82 differs from pull request most recent head 582a6bf. Consider uploading reports for the commit 582a6bf to get more accurate results

@@           Coverage Diff           @@
##           master    #5617   +/-   ##
=======================================
  Coverage   88.85%   88.85%           
=======================================
  Files         162      162           
  Lines       10962    10962           
  Branches     1894     1894           
=======================================
  Hits         9740     9740           
  Misses        942      942           
  Partials      280      280           

Copy link
Member

@Gallaecio Gallaecio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am thinking we should skip the tests instead, with @pytest.mark.skipIf(…, strict=True, reason="w3lib 2.0.0 and later do not allow invalid domains.").

Also, while I don’t think we need to address it here, we need to keep the target issue open or create a new one to actually figure out how to test IPv6 support now.

@Laerte
Copy link
Member Author

Laerte commented Sep 6, 2022

@Gallaecio Done.

tests/test_spider.py Outdated Show resolved Hide resolved
@wRAR wRAR merged commit 3f060ae into scrapy:master Sep 7, 2022
@Laerte Laerte deleted the fix/tests-w3lib branch September 7, 2022 12:29
@kmike kmike mentioned this pull request Sep 27, 2022
Gallaecio pushed a commit to Gallaecio/scrapy that referenced this pull request Sep 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants