New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix failed tests related to w3lib #5617
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5617 +/- ##
=======================================
Coverage 88.85% 88.85%
=======================================
Files 162 162
Lines 10962 10962
Branches 1894 1894
=======================================
Hits 9740 9740
Misses 942 942
Partials 280 280 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am thinking we should skip the tests instead, with @pytest.mark.skipIf(…, strict=True, reason="w3lib 2.0.0 and later do not allow invalid domains.")
.
Also, while I don’t think we need to address it here, we need to keep the target issue open or create a new one to actually figure out how to test IPv6 support now.
@Gallaecio Done. |
Fix failed tests related to w3lib
This fix failed tests from this issue: #5612
- tox.wiki is offline that's why checks is failing (tox-dev/tox#2486)