Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pin documentation requirements #5536

Merged
merged 1 commit into from Jun 20, 2022
Merged

Pin documentation requirements #5536

merged 1 commit into from Jun 20, 2022

Conversation

Gallaecio
Copy link
Member

@Gallaecio Gallaecio requested review from kmike and wRAR June 17, 2022 15:07
@Gallaecio Gallaecio mentioned this pull request Jun 17, 2022
Merged
@codecov
Copy link

codecov bot commented Jun 17, 2022 •
edited

Codecov Report

Merging #5536 (e601c55) into 2.6 (54bfb96) will not change coverage.
The diff coverage is n/a.

❗ Current head e601c55 differs from pull request most recent head 527fd3f. Consider uploading reports for the commit 527fd3f to get more accurate results

@@           Coverage Diff           @@
##              2.6    #5536   +/-   ##
=======================================
  Coverage   88.81%   88.81%           
=======================================
  Files         163      163           
  Lines       10675    10675           
  Branches     1821     1821           
=======================================
  Hits         9481     9481           
  Misses        918      918           
  Partials      276      276

kmike
kmike approved these changes Jun 17, 2022
View reviewed changes
Copy link
Member

@kmike kmike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

What do you think about applying the same fix to the master?

@Gallaecio
Copy link
Member Author

Since this is not a time-sensitive issue, I think it may be OK to merge in 2.6 only and post-pone the merge into master until the 2.6.2 release, when we should merge 2.6 back into master anyway.

@Gallaecio Gallaecio merged commit e3e69d1 into scrapy:2.6 Jun 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kmike kmike kmike approved these changes

@wRAR wRAR wRAR approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Gallaecio @kmike @wRAR