New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
If TWISTED_REACTOR is None, reuse any pre-installed reactor #5528
If TWISTED_REACTOR is None, reuse any pre-installed reactor #5528
Conversation
The documentation failure can be ignored, I plan to address that separately. |
Codecov Report
@@ Coverage Diff @@
## 2.6 #5528 +/- ##
==========================================
- Coverage 88.81% 88.27% -0.54%
==========================================
Files 163 163
Lines 10676 10563 -113
Branches 1821 1789 -32
==========================================
- Hits 9482 9325 -157
- Misses 918 955 +37
- Partials 276 283 +7
|
Hmm… I assumed Windows would be using one of the Windows-specific reactors, but I was wrong, and select seems to be the only crossplatform reactor (making it suitable for the failing test), so I will skip those tests on Windows. |
…pytest overriding the run-time reactor
Fixes #5525