Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If TWISTED_REACTOR is None, reuse any pre-installed reactor #5528

Merged
merged 7 commits into from Jun 17, 2022

Conversation

Gallaecio
Copy link
Member

Fixes #5525

@Gallaecio
Copy link
Member Author

Gallaecio commented Jun 14, 2022

The documentation failure can be ignored, I plan to address that separately.

@codecov
Copy link

codecov bot commented Jun 14, 2022

Codecov Report

Merging #5528 (22526ad) into 2.6 (1c1cd5d) will decrease coverage by 0.53%.
The diff coverage is 100.00%.

❗ Current head 22526ad differs from pull request most recent head 6b4c429. Consider uploading reports for the commit 6b4c429 to get more accurate results

@@            Coverage Diff             @@
##              2.6    #5528      +/-   ##
==========================================
- Coverage   88.81%   88.27%   -0.54%     
==========================================
  Files         163      163              
  Lines       10676    10563     -113     
  Branches     1821     1789      -32     
==========================================
- Hits         9482     9325     -157     
- Misses        918      955      +37     
- Partials      276      283       +7     
Impacted Files Coverage Δ
scrapy/crawler.py 88.46% <100.00%> (-0.37%) ⬇️
scrapy/utils/reactor.py 76.92% <100.00%> (ø)
scrapy/robotstxt.py 73.33% <0.00%> (-24.20%) ⬇️
scrapy/core/downloader/handlers/__init__.py 83.33% <0.00%> (-9.40%) ⬇️
scrapy/squeues.py 92.85% <0.00%> (-7.15%) ⬇️
scrapy/utils/ssl.py 65.85% <0.00%> (-4.88%) ⬇️
scrapy/utils/defer.py 91.83% <0.00%> (-4.13%) ⬇️
scrapy/pqueues.py 95.86% <0.00%> (-3.31%) ⬇️
scrapy/extensions/memdebug.py 45.00% <0.00%> (-2.62%) ⬇️
scrapy/downloadermiddlewares/cookies.py 95.74% <0.00%> (-2.16%) ⬇️
... and 62 more

@Gallaecio
Copy link
Member Author

Hmm… I assumed Windows would be using one of the Windows-specific reactors, but I was wrong, and select seems to be the only crossplatform reactor (making it suitable for the failing test), so I will skip those tests on Windows.

@Gallaecio Gallaecio marked this pull request as draft June 16, 2022 07:10
@Gallaecio Gallaecio marked this pull request as ready for review June 16, 2022 09:14
@Gallaecio Gallaecio merged commit 4ef7182 into scrapy:2.6 Jun 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants