Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin old markupsafe when we pin old mitmproxy. #5427

Merged
merged 1 commit into from Feb 23, 2022

Conversation

wRAR
Copy link
Member

@wRAR wRAR commented Feb 23, 2022

Fixes #5425

@codecov
Copy link

codecov bot commented Feb 23, 2022

Codecov Report

Merging #5427 (a4bad80) into master (3b42ccf) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #5427   +/-   ##
=======================================
  Coverage   88.77%   88.77%           
=======================================
  Files         163      163           
  Lines       10639    10639           
  Branches     1813     1813           
=======================================
  Hits         9445     9445           
  Misses        919      919           
  Partials      275      275           

@wRAR
Copy link
Member Author

wRAR commented Feb 23, 2022

tests/test_feedexport.py::BatchDeliveriesTest::test_batch_path_differ failed on almost all Windows envs which doesn't seem related...

@wRAR
Copy link
Member Author

wRAR commented Feb 23, 2022

And they didn't fail again after restarting.

@Gallaecio Gallaecio merged commit 08557e0 into scrapy:master Feb 23, 2022
@wRAR wRAR deleted the ci-mitmproxy-markupsafe branch May 8, 2023 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ImportError: cannot import name 'soft_unicode' from 'markupsafe'
2 participants