New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ItemLoaders can break if instantiated with pre-populated items #3897
Comments
Looks like a fine idea. Some tests needed to be sure. |
So to summarize my understanding:
Although I don't have any examples myself, I can think of two other ways this might break:
The second might be somewhat workaroundable by |
What about leaving the old behavior for |
Sorry for not answering, was quite ill (dentist), will look through it carefully next 3-5 days. Thank @andrewbaxter for the detailed vision :) |
Discussed with @andrewbaxter, going on vacation (for a ~week), will apply some solution firstly after :) |
Before I start, I know item loaders have been a big source of discussion for a long time; I'm only opening this issue because the latest release breaks some of our spiders.
In one of our projects, our Autounit tests fail under 1.7.1 due to some item loaders which are created from partially populated items. I suspect the relevant change is #3819 (which BTW I think inadvertently closes #3046).
Personally I think a better approach here would be something closer to the solution proposed in #3149, although not exactly the same.
Consider the following:
I'm not directly opening a PR because I think this needs discussion. What if we changed
to
which calls
arg_to_iter
internally?With that change, the following happens which is more reasonable IMHO:
Looking forward to reading your thoughts on the matter
/cc @Gallaecio @kmike @andrewbaxter @fcanobrash @sortafreel
The text was updated successfully, but these errors were encountered: