Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MRG+1] Fix missing values #3819

Merged
merged 5 commits into from Jun 13, 2019
Merged

[MRG+1] Fix missing values #3819

merged 5 commits into from Jun 13, 2019

Conversation

sortafreel
Copy link
Contributor

Issue: #3804

@Gallaecio
Copy link
Member

Could you please include an automated test covering your changes?

@codecov
Copy link

codecov bot commented Jun 11, 2019

Codecov Report

Merging #3819 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #3819      +/-   ##
==========================================
+ Coverage   85.42%   85.43%   +<.01%     
==========================================
  Files         169      169              
  Lines        9635     9637       +2     
  Branches     1433     1434       +1     
==========================================
+ Hits         8231     8233       +2     
  Misses       1156     1156              
  Partials      248      248
Impacted Files Coverage Δ
scrapy/loader/__init__.py 94.59% <100%> (+0.07%) ⬆️

@codecov
Copy link

codecov bot commented Jun 11, 2019 •
edited

Codecov Report

Merging #3819 into master will decrease coverage by 0.53%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #3819      +/-   ##
==========================================
- Coverage   85.42%   84.89%   -0.54%     
==========================================
  Files         169      169              
  Lines        9635     9637       +2     
  Branches     1433     1434       +1     
==========================================
- Hits         8231     8181      -50     
- Misses       1156     1202      +46     
- Partials      248      254       +6
Impacted Files Coverage Δ
scrapy/loader/__init__.py 94.59% <100%> (+0.07%) ⬆️
scrapy/core/downloader/handlers/s3.py 62.9% <0%> (-32.26%) ⬇️
scrapy/utils/boto.py 46.66% <0%> (-26.67%) ⬇️
scrapy/core/downloader/tls.py 77.5% <0%> (-12.5%) ⬇️
scrapy/extensions/feedexport.py 80.18% <0%> (-4.72%) ⬇️
scrapy/core/downloader/handlers/http11.py 89.92% <0%> (-2.62%) ⬇️
scrapy/core/scraper.py 86.48% <0%> (-2.03%) ⬇️
scrapy/pipelines/files.py 67.15% <0%> (-1.1%) ⬇️

@Gallaecio Gallaecio closed this Jun 11, 2019
@Gallaecio Gallaecio reopened this Jun 11, 2019
Gallaecio
Gallaecio approved these changes Jun 11, 2019
View reviewed changes
Copy link
Member

@Gallaecio Gallaecio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Failing tests are all unrelated.

tests/test_loader.py Outdated
@@ -709,28 +746,28 @@ def test_nested_load_item(self):


class SelectJmesTestCase(unittest.TestCase):
test_list_equals = {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💄 I would avoid these indentation fixes, being unrelated to the actual changes.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed, thanks :)

@Gallaecio Gallaecio changed the title Fix missing values [MRG+1] Fix missing values Jun 11, 2019
@sortafreel
Copy link
Contributor Author

As discussed with @Gallaecio, bugs are random and not caused by this pull request code changes.

victor-torres
victor-torres approved these changes Jun 11, 2019
View reviewed changes
Copy link
Contributor

@victor-torres victor-torres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dangra dangra merged commit c05d24c into scrapy:master Jun 13, 2019
@sortafreel sortafreel deleted the fix_missing_values branch June 13, 2019 14:15
@kmike kmike added this to the v1.7 milestone Jun 25, 2019
@kmike kmike mentioned this pull request Jul 4, 2019
Closed
@elacuesta elacuesta mentioned this pull request Jul 22, 2019
Closed
@Gallaecio Gallaecio mentioned this pull request Aug 1, 2019
Closed
Gallaecio added a commit that referenced this pull request Oct 21, 2019
@Gallaecio
Revert "Merge pull request #3819 from sortafreel/fix_missing_values"
3f411e3 
This reverts commit c05d24c, reversing
changes made to 66c40d0.
@pawelmhm pawelmhm mentioned this pull request Feb 23, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gallaecio Gallaecio Gallaecio approved these changes

@victor-torres victor-torres victor-torres approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.7
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@sortafreel @Gallaecio @victor-torres @dangra @kmike