Update pydantic dependency to >= 2 #76
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #76 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 4 4
Lines 306 307 +1
=========================================
+ Hits 306 307 +1
|
|
Thanks for the contribution. Changes might be ok for pydantic>=2, but we need to keep supporting pydantic<2. I'd recommend something like this set of changes (currently failing except for the |
bmwiedemann
pushed a commit
to bmwiedemann/openSUSE
that referenced
this pull request
Mar 20, 2024
https://build.opensuse.org/request/show/1159849 by user dgarcia + dimstar_suse - Add pydantic2.patch to make tests compatible with pydantic2 gh#scrapy/itemadapter#76
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have used bump-pydantic on the code base to do the initial migration.
Afterwards I had to work on some details (e.g.
__fields__->model_fields).Please note, that I am very unsure about the changes to
_get_pydantic_model_metadata(). Please review (or adapt as necessary)!Fixes #72