Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore and deprecate _unicode_safe_getattr. #133

Merged
merged 3 commits into from Oct 27, 2022
Merged

Conversation

wRAR
Copy link
Member

@wRAR wRAR commented Oct 27, 2022

No description provided.

@codecov
Copy link

codecov bot commented Oct 27, 2022

Codecov Report

Merging #133 (90b57c9) into master (89f1a86) will decrease coverage by 0.19%.
The diff coverage is 60.00%.

@@            Coverage Diff             @@
##           master     #133      +/-   ##
==========================================
- Coverage   95.66%   95.46%   -0.20%     
==========================================
  Files           2        2              
  Lines         899      904       +5     
  Branches      153      161       +8     
==========================================
+ Hits          860      863       +3     
- Misses         22       24       +2     
  Partials       17       17              
Impacted Files Coverage Δ
cssselect/xpath.py 94.13% <60.00%> (-0.51%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@wRAR
Copy link
Member Author

wRAR commented Oct 27, 2022

I've also documented private API changes in #131

@Gallaecio Gallaecio merged commit 60c6146 into master Oct 27, 2022
@wRAR wRAR deleted the deprecate-getattr branch October 27, 2022 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants