Defined encoding to utf-8 which was causing decode error in windows #998
Conversation
Codecov Report
@@ Coverage Diff @@
## master #998 +/- ##
=======================================
Coverage 98.29% 98.29%
=======================================
Files 234 234
Lines 2694 2694
=======================================
Hits 2648 2648
Misses 46 46 Continue to review full report at Codecov.
|
setup.py
Outdated
| @@ -5,7 +5,7 @@ | |||
| open('dateparser/__init__.py').read()).group(1) | |||
|
|
|||
| introduction = re.sub(r':members:.+|..\sautomodule::.+|:class:|:func:|:ref:', | |||
| '', open('docs/introduction.rst').read()) | |||
| '', open('docs/introduction.rst', encoding='utf-8').read()) | |||
| history = re.sub(r':mod:|:class:|:func:', '', open('HISTORY.rst').read()) | |||
There was a problem hiding this comment.
I believe you will also need to add utf-8 encoding for HISTORY.rst as well.
There was a problem hiding this comment.
Yes! you are correct. Thanks 😄
There was a problem hiding this comment.
Thanks for PR @atharmohammad and sorry for a late review. It looks great, but in e14655b the line endings in setup.py are changed, so the diff is showing that the whole file is changed (the line endings don't show up on github but are visible in the command line git). Would you mind fixing this?
Yeah! Sure. Fixing it |
atharmohammad
force-pushed
the
issue-978
branch
from
e14655b
to
a92b20c
Compare
|
@lopuhin have done the changes please have a look ! |
Closes #978