New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow to use_given_order for languages too #997
Allow to use_given_order for languages too #997
Conversation
Codecov Report
@@ Coverage Diff @@
## master #997 +/- ##
=======================================
Coverage 98.29% 98.29%
=======================================
Files 234 234
Lines 2694 2694
=======================================
Hits 2648 2648
Misses 46 46
Continue to review full report at Codecov.
|
507dc6d
to
fab5e91
Compare
Is that all that needs changing? (i.e. was the feature there but this exception was getting in the way?) Could you add a test? |
Yes, e.g. for French format is To solve it I wrote this class
And everything starts working
There is a test of loading languages with dateparser/tests/test_loading.py Lines 21 to 26 in 507dc6d
|
But it was not failing before. We need a test that would have caught the issue before your change, i.e. a test that fails if we revert your change, and passes after we apply it. And I don’t mean https://github.com/scrapinghub/dateparser/pull/997/files#diff-fd61b87100377a706498644e5ff42b8baecf18918169f6d4082af10d5a053477R658. |
No description provided.