Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for decade in hindi #986

Merged

Conversation

Mr-Sunglasses
Copy link
Contributor

Added support for decade in hindi language

@Mr-Sunglasses
Copy link
Contributor Author

@Gallaecio I fixed all the issues of my previous PR in this PR. I ran all the tests , Everything is fine.

@codecov
Copy link

codecov bot commented Sep 28, 2021

Codecov Report

Base: 98.23% // Head: 98.23% // No change to project coverage 👍

Coverage data is based on head (80ef759) compared to base (bcd1a3c).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #986   +/-   ##
=======================================
  Coverage   98.23%   98.23%           
=======================================
  Files         232      232           
  Lines        2605     2605           
=======================================
  Hits         2559     2559           
  Misses         46       46           
Impacted Files Coverage Δ
dateparser/data/date_translation_data/hi.py 100.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@Gallaecio Gallaecio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

@serhii73 serhii73 closed this Oct 31, 2022
@serhii73 serhii73 reopened this Oct 31, 2022
@wRAR
Copy link
Member

wRAR commented Nov 3, 2022

AssertionError: The content of the file "../dateparser/data/date_translation_data/hi.py" doesn't match the content of the generated file.

@Mr-Sunglasses
Copy link
Contributor Author

Fixing it 🙂 @wRAR

@serhii73
Copy link
Collaborator

I've fixed that error.
Thank you for your PR @Mr-Sunglasses

@serhii73 serhii73 merged commit 1bff509 into scrapinghub:master Nov 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants