Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add 'ago' to french relative parsing #1110

Merged
merged 1 commit into from Dec 29, 2022
Merged

Add 'ago' to french relative parsing #1110

merged 1 commit into from Dec 29, 2022

Conversation

gutsytechster
Copy link
Collaborator

This fixes #1102

@wRAR
Copy link
Member

wRAR commented Dec 17, 2022

Does French really use the English word "ago" in the same way English uses it? I can't find anything that proves it.

@serhii73 serhii73 self-requested a review December 19, 2022 11:29
@serhii73
Copy link
Collaborator

Looks like you're right @wRAR
Can you please check @gutsytechster this link: https://www.interglot.com/dictionary/fr/fr/translate/il%20y%20a
Thanks in advance.

@Gallaecio Gallaecio mentioned this pull request Dec 19, 2022
Closed
@gutsytechster
Copy link
Collaborator Author

I understood from the initial issue that the English word ago is used along with the French word. I also checked the dictionary with @serhii73 mentioned in the above message, and I don't see any french word ago in that. So it shouldn't have any other meaning besides the English meaning.

@serhii73
Copy link
Collaborator

I guess it makes sence just add a test for:

from dateparser import parse

parse('4 heures ago')

>> None

And don't add ago to French. What do you think, guys?

@wRAR
Copy link
Member

wRAR commented Dec 28, 2022

Yeah.

@gutsytechster
tests(test_freshness_date_parser.py): add test case for french + engl…
ef23f4b 
…ish string

The parser shouldn't scrape such a case.
@Gallaecio Gallaecio merged commit d28fd0d into scrapinghub:master Dec 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gallaecio Gallaecio Gallaecio approved these changes

@serhii73 serhii73 serhii73 approved these changes

@wRAR wRAR Awaiting requested review from wRAR

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

French issue
4 participants
@gutsytechster @wRAR @serhii73 @Gallaecio