Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace regex sub with simple string replace #1095

Merged
merged 2 commits into from Nov 14, 2022

Conversation

DJRHails
Copy link
Contributor

@DJRHails DJRHails commented Nov 11, 2022

Fixes #1045

Updates from: #1067 (closes #1067)

@codecov
Copy link

codecov bot commented Nov 14, 2022

Codecov Report

Base: 98.23% // Head: 98.23% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (7516f5e) compared to base (0cbf46a).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1095      +/-   ##
==========================================
- Coverage   98.23%   98.23%   -0.01%     
==========================================
  Files         232      232              
  Lines        2605     2604       -1     
==========================================
- Hits         2559     2558       -1     
  Misses         46       46              
Impacted Files Coverage Δ
dateparser/languages/locale.py 98.69% <100.00%> (-0.01%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@Gallaecio Gallaecio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@serhii73 serhii73 merged commit 0f5d9c5 into scrapinghub:master Nov 14, 2022
@DJRHails DJRHails deleted the fix/regex-incompatibility branch November 14, 2022 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bad escape characters trigger an exception
3 participants