Fix Ukrainian supplemental data to be in the yaml and restored CLDR data #1090
+102
−129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wRAR
approved these changes
Oct 24, 2022
Codecov ReportBase: 98.23% // Head: 98.23% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #1090 +/- ##
=======================================
Coverage 98.23% 98.23%
=======================================
Files 232 232
Lines 2602 2602
=======================================
Hits 2556 2556
Misses 46 46
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
serhii73
approved these changes
Oct 24, 2022
|
Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems like #1079 was merged even though it modified the CLDR json. These translations should have been added to the supplementary yaml files instead.
This PR restores the JSON to it's original data and adds the translations from #1079 to the YAML file.
This is currently blocking other PRs, specifically #876.