Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Japanese support #1068

Merged
merged 2 commits into from Nov 14, 2022
Merged

Conversation

smurak
Copy link
Contributor

@smurak smurak commented Aug 12, 2022

Thank you for maintaining this very useful library.

I've just improved Japanese support a little.
Please check if this is ok.

@serhii73
Copy link
Collaborator

Hi @smurak
Could you please resolve the conflicts? Thanks in advance.

@smurak
Copy link
Contributor Author

smurak commented Nov 11, 2022

Hi @smurak Could you please resolve the conflicts? Thanks in advance.

Thanks for checking, @serhii73 .
Resolved conflicts.

@codecov
Copy link

codecov bot commented Nov 11, 2022

Codecov Report

Base: 98.23% // Head: 98.23% // No change to project coverage 👍

Coverage data is based on head (f2dfdfd) compared to base (0cbf46a).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1068   +/-   ##
=======================================
  Coverage   98.23%   98.23%           
=======================================
  Files         232      232           
  Lines        2605     2605           
=======================================
  Hits         2559     2559           
  Misses         46       46           
Impacted Files Coverage Δ
dateparser/data/date_translation_data/ja.py 100.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Collaborator

@serhii73 serhii73 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Gallaecio Gallaecio merged commit 7636266 into scrapinghub:master Nov 14, 2022
@Gallaecio
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants