support for dates with dots and spaces #1028
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1028 +/- ##
=======================================
Coverage 98.29% 98.29%
=======================================
Files 234 234
Lines 2694 2694
=======================================
Hits 2648 2648
Misses 46 46
Continue to review full report at Codecov.
|
|
@Gallaecio sorry to bother but can you look into this PR? This is a regression for us (#1010) 🙏 Many thanks! |
Gallaecio
approved these changes
Jun 22, 2022
| @@ -223,7 +223,7 @@ class _parser: | |||
|
|
|||
| def __init__(self, tokens, settings): | |||
| self.settings = settings | |||
| self.tokens = list(tokens) | |||
| self.tokens = [(t[0].strip(), t[1]) for t in list(tokens)] | |||
There was a problem hiding this comment.
I wonder if we can drop the list cast now:
Suggested change
| self.tokens = [(t[0].strip(), t[1]) for t in list(tokens)] | |
| self.tokens = [(t[0].strip(), t[1]) for t in tokens] |
| @@ -35,7 +35,7 @@ | |||
|
|
|||
| RE_SANITIZE_SKIP = re.compile(r'\t|\n|\r|\u00bb|,\s\u0432\b|\u200e|\xb7|\u200f|\u064e|\u064f', flags=re.M) | |||
| RE_SANITIZE_RUSSIAN = re.compile(r'([\W\d])\u0433\.', flags=re.I | re.U) | |||
| RE_SANITIZE_PERIOD = re.compile(r'(?<=\D+)\.', flags=re.U) | |||
| RE_SANITIZE_PERIOD = re.compile(r'(?<=[^0-9\s])\.', flags=re.U) | |||
There was a problem hiding this comment.
💄
Suggested change
| RE_SANITIZE_PERIOD = re.compile(r'(?<=[^0-9\s])\.', flags=re.U) | |
| RE_SANITIZE_PERIOD = re.compile(r'(?<=[^\d\s])\.', flags=re.U) |
gutsytechster
approved these changes
Jun 22, 2022
|
Can someone merge this to fix #1010 ? 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1010
this will support dates such as
26 .10.21or26 . 10.21, in date26 . 10.21the first period was getting removed in sanitization even when it was between numerals only(surrounded by spaces) which was not needed. that is why changed the period sanitization regex a bit