New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #403 #1002
Fix #403 #1002
Conversation
Could you please include a test for the fix? |
Codecov Report
@@ Coverage Diff @@
## master #1002 +/- ##
=======================================
Coverage 98.29% 98.29%
=======================================
Files 234 234
Lines 2694 2697 +3
=======================================
+ Hits 2648 2651 +3
Misses 46 46
Continue to review full report at Codecov.
|
Thanks for the comments.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work!
The parse function only works with naive times, so this provides timezone information to compute the offset from utc and provide
_correct_for_time_frame
with the utc time instead of local time as_correct_for_time_frame
checks if the time has passed in utc.This fixes #403