Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bitstring 4.0.0 doesn't work with python 3.7 #240

Closed
alexjacobson95 opened this issue Nov 16, 2022 · 5 comments
Closed

Bitstring 4.0.0 doesn't work with python 3.7 #240

alexjacobson95 opened this issue Nov 16, 2022 · 5 comments
Assignees
Milestone

Comments

@alexjacobson95
Copy link
Contributor

alexjacobson95 commented Nov 16, 2022

First off, thanks for this awesome package, it's a huge help to me. But I wanted to let you know that the latest 4.0.0 release of bitstring seems to have broken 3.7 support. Looks like SupportsIndex doesn't exist in the typing module for python 3.7, and thus errors out on import. I tried bitstring 3.1.9 and had no issues. Example below:

>>> import bitstring
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/mnt/d/Alex/Documents/repos/bitstring/bitstring.py", line 75, in <module>
    from typing import Generator, SupportsIndex, Tuple, Union, List, Iterable, Any, Optional, Iterator, Pattern, Dict,\
ImportError: cannot import name 'SupportsIndex' from 'typing' (/home/alex/.pyenv/versions/3.7.15/lib/python3.7/typing.py)
>>>

Looks like SupportsIndex was added in python 3.8: https://docs.python.org/3.8/library/typing.html#typing.SupportsIndex

alexjacobson95 added a commit to alexjacobson95/bitstring that referenced this issue Nov 16, 2022
@scott-griffiths
Copy link
Owner

Oops. Looks like my test harness was broken! Thanks for letting me know - I'll fix today.

@scott-griffiths scott-griffiths self-assigned this Nov 16, 2022
@scott-griffiths scott-griffiths added this to the 4.0 milestone Nov 16, 2022
scott-griffiths added a commit that referenced this issue Nov 16, 2022
@scott-griffiths
Copy link
Owner

Yep, looks like my Python3.7 unit test runner accidentally got upgraded to use Python 3.11. :(

@Bastian-Krause
Copy link

@scott-griffiths Do you plan to make a bug fix release for this?

@scott-griffiths
Copy link
Owner

@Bastian-Krause Yep. Already done. Latest is 4.0.1 which (fingers crossed) should be good this time!

@Bastian-Krause
Copy link

@scott-griffiths Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants