Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility with attrs v22.1.0 #144

Closed
XN137 opened this issue Aug 1, 2022 · 2 comments · Fixed by #145
Closed

Compatibility with attrs v22.1.0 #144

XN137 opened this issue Aug 1, 2022 · 2 comments · Fixed by #145
Labels
enhancement New feature or request
Milestone

Comments

@XN137
Copy link

XN137 commented Aug 1, 2022

Description

dependabot tried upgrading attrs to 22.1.0 in our repo resulting in this pip install error:

  The conflict is caused by:
      The user requested attrs==22.1.0
      desert 2020.11.18 depends on attrs
      pytest 7.1.2 depends on attrs>=19.2.0
      pytest-mypy 0.9.1 depends on attrs>=19.0
      pytest-recording 0.12.1 depends on attrs
      flake8-annotations 2.9.0 depends on attrs<22.0 and >=21.4

Rationale/Use Case
If there are no strong reasons to version cap the attrs dependency maybe it could be less strict or at least support 22.1.x for the time being.
Thank you.

@XN137 XN137 added the enhancement New feature or request label Aug 1, 2022
@sco1
Copy link
Owner

sco1 commented Aug 1, 2022

That can probably be relaxed without any issues, I'll try to take a look at it this afternoon.

@sco1 sco1 added this to the 2.9.1 milestone Aug 1, 2022
@sco1 sco1 mentioned this issue Aug 1, 2022
@sco1 sco1 closed this as completed in #145 Aug 1, 2022
@XN137
Copy link
Author

XN137 commented Aug 2, 2022

Just wanted to confirm that the problem is indeed resolved when combining the 2 new versions.
Thank you for the quick response.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants