Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't ship CHANGELOG with wheels #117

Closed
akx opened this issue Jun 15, 2021 · 1 comment
Closed

Don't ship CHANGELOG with wheels #117

akx opened this issue Jun 15, 2021 · 1 comment
Labels
bug Something isn't working

Comments

@akx
Copy link

akx commented Jun 15, 2021

Describe the bug

Upon uninstalling the package (temporarily, don't worry! 馃榿 ), I noticed it had dropped a CHANGELOG.md in site-packages. It probably shouldn't.

$ pip uninstall flake8-annotations
Found existing installation: flake8-annotations 2.6.2
Uninstalling flake8-annotations-2.6.2:
  Would remove:
    .../lib/python3.9/site-packages/CHANGELOG.md
    .../lib/python3.9/site-packages/flake8_annotations-2.6.2.dist-info/*
    .../lib/python3.9/site-packages/flake8_annotations/*

To Reproduce

Minimal code example to reproduce the behavior:

  • install flake8-annotations
  • look in your site-packages

Version Information

  • flake8-annotations 2.6.2
  • Python 3.9
  • pip 20.3.1
@akx akx added the bug Something isn't working label Jun 15, 2021
@sco1
Copy link
Owner

sco1 commented Jun 15, 2021

Interesting! Never noticed this. I guess I've never uninstalled 馃槃

I think this was just copied from Poetry's documentation when this was moved from pipenv. I'll change it now so future releases won't do this.

Thanks!

@sco1 sco1 closed this as completed in 3419a22 Jun 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants