-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Assemble process should be cleaner #42
Comments
@michaelryanmcneill Thanks. PullRequests are really welcomed.
|
@michaelryanmcneill Can you please file a PR, including test suite? |
phracek
added a commit
that referenced
this issue
Apr 17, 2024
here: https://github.com/sclorg/s2i-php-container/blob/master/8.1/s2i/bin/assemble#L7 Closes: #42 Signed-off-by: Petr "Stone" Hracek <phracek@redhat.com>
phracek
added a commit
that referenced
this issue
Jun 5, 2024
* Fixes: #42 Moving sources instead of copying sources like it is done here: https://github.com/sclorg/s2i-php-container/blob/master/8.1/s2i/bin/assemble#L7 * Add distgen generated files Closes: #42 Signed-off-by: Petr "Stone" Hracek <phracek@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Instead of copying all the files, we should follow what https://github.com/sclorg/s2i-php-container/blob/master/7.0/s2i/bin/assemble does, which is:
This prevents moving the .git directory with it.
In addition, I'm not sure I see a need to cat the default.vcl file on each build. What is the use besides the occasional debugging?
The text was updated successfully, but these errors were encountered: