BLD: fix issue with incomplete threads dependency handling #17200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All could using `#include <thread>` needs to have this `thread_dep` dependency. HiGHS code was missing it, and for `stats/_qmc_cy.pyx` it was incorrectly specified. It's wrong in the distutils build as well, but let's ignore that since it's much harder to change and we'll get rid of that build soon. See scipygh-17193 for the type of compile error this causes.
There was a problem hiding this comment.
LGTM, maybe we should allow some time for @zheddie to confirm the fix though.
zheddie
pushed a commit
to zheddie/scipy
that referenced
this pull request
Oct 12, 2022
|
@zheddie confirmed this works on OS/400 in #17193 (comment). |
rgommers
added
the
backport-candidate
zheddie
pushed a commit
to zheddie/scipy
that referenced
this pull request
Oct 12, 2022
ev-br
pushed a commit
to ev-br/scipy
that referenced
this pull request
Oct 14, 2022
All could using `#include <thread>` needs to have this `thread_dep` dependency. HiGHS code was missing it, and for `stats/_qmc_cy.pyx` it was incorrectly specified. It's wrong in the distutils build as well, but let's ignore that since it's much harder to change and we'll get rid of that build soon. See scipygh-17193 for the type of compile error this causes. [ci skip]
tylerjereddy
pushed a commit
to tylerjereddy/scipy
that referenced
this pull request
Oct 16, 2022
All could using `#include <thread>` needs to have this `thread_dep` dependency. HiGHS code was missing it, and for `stats/_qmc_cy.pyx` it was incorrectly specified. It's wrong in the distutils build as well, but let's ignore that since it's much harder to change and we'll get rid of that build soon. See scipygh-17193 for the type of compile error this causes. [ci skip]
tylerjereddy
removed
the
backport-candidate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All code using
#include <thread>needs to have thisthread_depdependency. HiGHS code was missing it, and forstats/_qmc_cy.pyxit was incorrectly specified.It's wrong in the distutils build as well, but let's ignore that since it's much harder to change and we'll get rid of that build soon.
See gh-17193 for the type of compile error this causes.