Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: stats.pearsonr: typo in coeffic*i*ent #17153

Merged
merged 1 commit into from Oct 5, 2022
Merged

DOC: stats.pearsonr: typo in coeffic*i*ent #17153

merged 1 commit into from Oct 5, 2022

Conversation

wenig
Copy link

@wenig wenig commented Oct 5, 2022

What does this implement/fix?

There was a typo in the documentation for the stats.pearsonr function. "coefficent" is now changed to "coefficient".

@j-bowhay j-bowhay added scipy.stats Documentation Issues related to the SciPy documentation. Also check https://github.com/scipy/scipy.org labels Oct 5, 2022
@j-bowhay
Copy link
Member

j-bowhay commented Oct 5, 2022

For future reference please see https://scipy.github.io/devdocs/dev/contributor/rendering_documentation.html, specifically the section relating to skipping CI

Copy link
Member

@tupui tupui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @wenig. Next time please try to group more changes. We don't encourage single typo-like PRs.

Just a question, is this PR linked to hacktoberfest?

@tupui tupui merged commit 24dce97 into scipy:maintenance/1.9.x Oct 5, 2022
@tupui
Copy link
Member

tupui commented Oct 5, 2022

Ark sorry @tylerjereddy i am seeing the PR was made against maintenance instead of main. Feel free to revert. (DX is really not clear enough).

@tylerjereddy tylerjereddy added this to the 1.9.2 milestone Oct 5, 2022
@tylerjereddy
Copy link
Contributor

no worries in this case because it is so minor, I guess you can just forward port; this does happen by accident once or twice a year, I agree it is easy to miss

@tupui
Copy link
Member

tupui commented Oct 5, 2022

Well apparently it was already on main in #17016 so we are good. So yeah, feel free to just remove at all the commit and force push. In such case I think it's ok. Again sorry for the noise 🙃

@wenig
Copy link
Author

wenig commented Oct 7, 2022

Thank you @wenig. Next time please try to group more changes. We don't encourage single typo-like PRs.

Just a question, is this PR linked to hacktoberfest?

I see, will keep that in mind! No it's not linked to hacktoberfest. I have just read the docu for the pearsonr function and stumbled across the typo.

@wenig wenig deleted the maintenance/1.9.x branch October 7, 2022 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Issues related to the SciPy documentation. Also check https://github.com/scipy/scipy.org scipy.stats
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants