Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: stats.pearson3: fix ppf for negative skew #17055

Merged
merged 2 commits into from Oct 3, 2022
Merged

Conversation

mdhaber
Copy link
Contributor

@mdhaber mdhaber commented Sep 20, 2022

Reference issue

Closes gh-17050

What does this implement/fix?

gh-17050 reported that pearson3.ppf was incorrect for negative values of skew. The fix is similar to that for cdf in gh-12640 - use the fact that pearson3.ppf(x, skew) = -pearson3.ppf(1-x, -skew).

@mdhaber mdhaber added defect A clear bug or issue that prevents SciPy from being installed or used as expected scipy.stats labels Sep 20, 2022
@mdhaber mdhaber requested a review from ev-br as a code owner September 20, 2022 04:39
@mdhaber mdhaber added the backport-candidate This fix should be ported by a maintainer to previous SciPy versions. label Oct 3, 2022
@mdhaber mdhaber added this to the 1.9.2 milestone Oct 3, 2022
@mdhaber mdhaber requested a review from tupui October 3, 2022 00:52
@mdhaber
Copy link
Contributor Author

mdhaber commented Oct 3, 2022

It would be good to get this in 1.9.2.

Copy link
Member

@tupui tupui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and failure seems unrelated to me. Thanks Matt

@tupui tupui merged commit 942426a into scipy:main Oct 3, 2022
@mdhaber mdhaber mentioned this pull request Oct 4, 2022
tylerjereddy pushed a commit to tylerjereddy/scipy that referenced this pull request Oct 5, 2022
@tylerjereddy tylerjereddy removed the backport-candidate This fix should be ported by a maintainer to previous SciPy versions. label Oct 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
defect A clear bug or issue that prevents SciPy from being installed or used as expected scipy.stats
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pearson3 PPF does not function properly with negative skew.
3 participants