MAINT: final backports for 1.9.0 #16727
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ci skip]
Because of a bug in Cython, the inner function weigh() (a closure in _weightedrankedtau()) cannot refer to the memoryview arguments of _weightedrankedtau(). The work-around here is to assign the arguments to local variables.
* changes to lists after backports * manually remove the note that says SciPy is "not released yet," as we prepare for the final release
tylerjereddy
requested review from
larsoner,
rgommers and
andyfaff
as code owners
mdhaber
approved these changes
Jul 28, 2022
tupui
approved these changes
Jul 28, 2022
|
Failure in |
rgommers
approved these changes
Jul 28, 2022
|
Wheels builds started late Thursday evening |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports for:
Note that 15e96a0 was pushed in directly to the release branch by accident at some point, but I believe it can be left as is--@tupui indicates it was a sphinx-related pin suggested by @rgommers.
1.9.0release imminently1.9.0final "unreleased" (gets set to released during final prep) by removing thercstringsFinally, if you know of any reason not to release
1.9.0in the next day or two, let me know, otherwise I assume we are good to go.