MAINT: optimize.linprog: ensure integrality can be an array #16684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdhaber
added
defect
erip
reviewed
Jul 28, 2022
| @@ -581,7 +581,7 @@ def linprog(c, A_ub=None, b_ub=None, A_eq=None, b_eq=None, | |||
| warning_message = "x0 is used only when method is 'revised simplex'. " | |||
| warn(warning_message, OptimizeWarning) | |||
|
|
|||
| if integrality and not meth == "highs": | |||
There was a problem hiding this comment.
This isn't equivalent, right?
>>> a = [0, 0]
>>> if a:
... print("here")
...
here
>>> if np.any(a):
... print("here 2")
...
>>>There was a problem hiding this comment.
No, but it's appropriate in context. It's just a little less noisy. Previously, it would warn if the user passed [0, 0], but explicitly stating that there are no inequality constraints like this doesn't affect the problem, so there's no real need to warn.
mdhaber
added a commit
to mdhaber/scipy
that referenced
this pull request
Jul 28, 2022
tylerjereddy
pushed a commit
to tylerjereddy/scipy
that referenced
this pull request
Jul 28, 2022
tylerjereddy
removed
the
backport-candidate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference issue
Closes gh-16681
What does this implement/fix?
scipy.optimize.lingprog's newintegralityparameter did not acceptnp.ndarraybecause a branching statement relied on its "truthiness" (i.e.if integrality). This PR fixes that and adds to an existing test to guard against regression.