BUG: Fix alignment errors due to relaxed stride checking #14893
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference issue
Fixes errors in MacPython/scipy-wheels#132
What does this implement/fix?
NumPy's relaxed stride checking explicitly ignores length-1 dimensions, so if we don't as well then there will be false-positives as we were seeing in the windows build with python 3.10.
https://github.com/numpy/numpy/blob/5cb560616abe44774d897a80970775d2a26bb03b/numpy/core/src/common/array_assign.c#L114-L118