Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MAINT: disable include/source coverage warning. #14803

Merged
merged 2 commits into from Oct 4, 2021
Merged

MAINT: disable include/source coverage warning. #14803

merged 2 commits into from Oct 4, 2021

Conversation

tupui
Copy link
Member

@tupui tupui commented Oct 4, 2021 •
edited

Fixes #14802

Mitigate coverage_full_tests failure.

Starting with coverage 6, the warning --include is ignored because --source is set (include-ignored) is making the CI fail.

This PR just catches the warning.

#14653 will improve the coverage setup further. xref #14801

@tupui tupui added defect A clear bug or issue that prevents SciPy from being installed or used as expected maintenance Items related to regular maintenance tasks CI Items related to the CI tools such as CircleCI, GitHub Actions or Azure labels Oct 4, 2021
@tupui tupui requested a review from larsoner as a code owner October 4, 2021 10:25
@github-actions github-actions bot removed the CI Items related to the CI tools such as CircleCI, GitHub Actions or Azure label Oct 4, 2021
@tupui tupui added the CI Items related to the CI tools such as CircleCI, GitHub Actions or Azure label Oct 4, 2021
tirthasheshpatel
tirthasheshpatel reviewed Oct 4, 2021
View reviewed changes
.coveragerc Outdated Show resolved Hide resolved
@tupui @tirthasheshpatel
Update .coveragerc
54c1056 
Co-authored-by: Tirth Patel <tirthasheshpatel@gmail.com>
@github-actions github-actions bot removed the CI Items related to the CI tools such as CircleCI, GitHub Actions or Azure label Oct 4, 2021
@tupui
Copy link
Member Author

tupui commented Oct 4, 2021 •
edited

@tirthasheshpatel seems like it fixes it. (It's running now https://dev.azure.com/scipy-org/SciPy/_build/results?buildId=14157&view=logs&s=7cadbae7-7533-548a-becd-a2da10fc0146&j=71a75959-4ac6-5325-7763-a4017311fdf7)

tirthasheshpatel
tirthasheshpatel approved these changes Oct 4, 2021
View reviewed changes
Copy link
Member

@tirthasheshpatel tirthasheshpatel left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. As this doesn't touch any code/doc files, we can ignore other tests. I will look into this more deeply in gh-14653. Merging. Thanks, @tupui!

@tirthasheshpatel tirthasheshpatel merged commit 5938242 into scipy:master Oct 4, 2021
@tupui
Copy link
Member Author

tupui commented Oct 4, 2021

Great, we can finally have a green CI again 😅

@tupui tupui deleted the ci_cov_warning branch October 4, 2021 10:57
@tylerjereddy tylerjereddy added this to the 1.8.0 milestone Oct 4, 2021
@tylerjereddy tylerjereddy added the backport-candidate This fix should be ported by a maintainer to previous SciPy versions. label Oct 4, 2021
@tylerjereddy tylerjereddy mentioned this pull request Oct 27, 2021
Merged
rgommers pushed a commit to rgommers/scipy that referenced this pull request Oct 29, 2021
@tupui @rgommers
MAINT: disable include/source coverage warning. (scipy#14803)
6c4e648 
* MAINT: disable include/source coverage warning.

Co-authored-by: Tirth Patel <tirthasheshpatel@gmail.com>
(cherry picked from commit 5938242)
@tylerjereddy tylerjereddy modified the milestones: 1.8.0, 1.7.2 Oct 29, 2021
@tylerjereddy tylerjereddy removed the backport-candidate This fix should be ported by a maintainer to previous SciPy versions. label Oct 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tirthasheshpatel tirthasheshpatel tirthasheshpatel approved these changes

@larsoner larsoner Awaiting requested review from larsoner

Assignees
No one assigned
Labels
defect A clear bug or issue that prevents SciPy from being installed or used as expected maintenance Items related to regular maintenance tasks
Projects
None yet
Milestone
1.7.2
Development

Successfully merging this pull request may close these issues.

CI: Azure Main coverage job failure
3 participants
@tupui @tirthasheshpatel @tylerjereddy