Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: 1.6.0 rc2 backports #13279

Merged
merged 13 commits into from Dec 22, 2020

Conversation

tylerjereddy
Copy link
Contributor

tylerjereddy and others added 13 commits December 21, 2020 09:25
* the changes made to `pavement.py`, as described in scipygh-13221,
modernized some file handling code blocks as suggested by static
analysis

* however, this broke the usage of `paver release` (which is not
tested in CI), because the meaning of those code blocks was changed
from passing a path-like object to `os.path.basename()` to passing
an open file handle to `basename()`

* this two-character patch restores the originally intended meaning
(passing a path-like object to `basename()`) while preserving
the modernized file context managers; I confirmed locally that
`paver release` works again with this patch
* update the SciPy `1.6.0` (rc2) release notes following
backports to the maintenance branch

* I've added Matti Picus to the author list because
they made essential contributions to the wheels repo
that were not picked up by our automated scripts

* backports included for rc2 (so far):
scipygh-13226
scipygh-13249
scipygh-13253
scipygh-13260
scipygh-13269
@tylerjereddy tylerjereddy added the maintenance Items related to regular maintenance tasks label Dec 21, 2020
@tylerjereddy tylerjereddy added this to the 1.6.0 milestone Dec 21, 2020
Copy link
Member

@rgommers rgommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Tyler. All of those LGTM and all green, so I'll merge.

@rgommers rgommers merged commit 939ecfc into scipy:maintenance/1.6.x Dec 22, 2020
@rgommers
Copy link
Member

I removed the backport label from these. There's still 13 PRs with a backport label left, but it looks like those are all stale labels and could be cleared, right?

@tylerjereddy tylerjereddy deleted the treddy_160rc2_backports branch December 22, 2020 14:35
@tylerjereddy
Copy link
Contributor Author

yeah, I should double check and clear those labels

@tylerjereddy
Copy link
Contributor Author

tylerjereddy commented Dec 22, 2020

Ok, there are no longer any merged PRs with backport labels (I checked them all and cleared them).

1.6.0rc2 wheels are building now so perhaps I'll get that out this evening, depending on the wheel build queues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Items related to regular maintenance tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants