BUG:linalg: Fix heevx wrappers and add new tests #13255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilayn
added
defect
tylerjereddy
added
the
backport-candidate
|
Apart from the under-the-weather GH Actions for MacOS, this is ready for review. |
rgommers
approved these changes
Dec 23, 2020
|
@tylerjereddy unless there will be a |
|
ok, noted, thanks |
tylerjereddy
added a commit
to tylerjereddy/scipy
that referenced
this pull request
Dec 30, 2020
* backport the patch itself but not the testing changes; see: scipy#13255 (comment)
tylerjereddy
added a commit
to tylerjereddy/scipy
that referenced
this pull request
Dec 30, 2020
* update the `1.6.0` release notes after the backporting of scipygh-13255 (the patch proper, but not the testing changes--see comments there) and to remove the "Note" about `1.6.0` not being released yet * bump the version to `1.6.0` "final" (removing the rc2) unreleased
tylerjereddy
removed
the
backport-candidate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference issue
Closes #13239
What does this implement/fix?
The heevx LAPACK wrappers were practically untested due to having tests constrained to real data and hence no
hedriver is being triggered. Even their signature was incorrect however we heard nothing about this so far which is good for breaking compatibility concerns.This PR fixes the wrappers and adds the complex data to the tests.