Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: SciPy 1.5.0rc2 backports #12345

Merged

Conversation

tylerjereddy
Copy link
Contributor

@tylerjereddy tylerjereddy commented Jun 11, 2020

Backports included for those PRs with 1.6.0 milestone and a current backport label:

I have a lingering suspicion I may also need to backport a CircleCI sphinx version pinning for CI to pass as well, though no such PR was labelled as above--I guess we'll see what happens.

Release notes also updated based on above backports.

rgommers and others added 5 commits June 10, 2020 20:38
It looks like a bug in a particular OpenBLAS version that we use in
python3.7-dbg in CI.
Using np.prod(..., dtype=int) can overflow on 32-bit platforms.
Use scipy._lib._util.prod instead.
Cobyla is not threadsafe and can segfault when called from more than one thread.
The problem is in f2py. Until the problem is fixed upstream in NumPy (f2py) we must
synchronize the calls to cobyla with a lock.
* update the release notes for SciPy `1.5.0rc2`
backports
@tylerjereddy tylerjereddy added the maintenance Items related to regular maintenance tasks label Jun 11, 2020
@tylerjereddy tylerjereddy added this to the 1.5.0 milestone Jun 11, 2020
@larsoner
Copy link
Member

Yep, looks like you'll need #12335, which I just now marked as backport-candidate (sorry about that!)

@tylerjereddy
Copy link
Contributor Author

I think I need a backport for pydata/sparse related fix in Travis CI re: Python 3.7 + NumPy dev wheels cc @hameerabbasi

I thought we fixed that somewhere--I'll try to dig it up, should be fairly recent

@hameerabbasi
Copy link
Contributor

It's #12123.

@tylerjereddy
Copy link
Contributor Author

It must be something else--that PR is already in the maintenance branch. I think Pauli did another more recently.

@tylerjereddy
Copy link
Contributor Author

Ah yes, Pauli added a skip on the pydata/sparse install from NumPy pre-wheels in our CI here: #12285

So I'll probably want to backport that

pv and others added 3 commits June 12, 2020 09:23
The run is too slow for the test suite to complete, so split it into two
batches.
Numpy prerelease appears to cause problems for pydata/sparse, so avoid
running tests concerning it.
* update `1.5.0` release notes to include scipygh-12285
@tylerjereddy
Copy link
Contributor Author

That 32-bit Windows Azure job/mingw DL time is highly problematic; I'll give it one more restart..

@tylerjereddy
Copy link
Contributor Author

Ok, I restarted the 32-bit Windows Azure CI job 3 or 4 times and it never finished on time. However, the most recent run clearly shows that the test suite did pass and time simply ran out in the subsequent cleanup stages, so this should be safe to merge and I'm behind schedule, so in it goes.

@tylerjereddy tylerjereddy merged commit 896480b into scipy:maintenance/1.5.x Jun 13, 2020
@tylerjereddy tylerjereddy deleted the treddy_150rc2_backports branch June 13, 2020 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Items related to regular maintenance tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants