Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The javascript to generate the "out of date docs" warning for old NumPy docs should only point to numpy.org #73

Open
mattip opened this issue Feb 5, 2023 · 1 comment

Comments

@mattip
Copy link
Contributor

mattip commented Feb 5, 2023

Currently the "out of date" docs warning on older NumPy docs shows this

This is documentation for an old release of NumPy (version 1.9.2). Search for this page in the documentation of the latest stable release (version > 1.17).

The first link points to the docs on https://docs.scipy.org, where it should only refer to the newer documentation on https://numpy.org. I think we can remove the first link entirely. The idea was that perhaps the newer documentation has the same structure, so the link can be recreated to the newer docs, but by now the structure has changed so much that will rarely succeed.

xref numpy/numpy#23156

@tupui
Copy link
Member

tupui commented Feb 6, 2023

Indeed. The first link is created using this

const searchUrl = "https://docs.scipy.org/doc/scipy/search.html?q=" + encodeURI(searchWords);

We could either remove it entirely, or as with other links in the code and use some conditional.

NumPy's doc is also using this JS or you have a copy on your side? In the long run, we might not have to support this mechanism anymore since the theme is having something for that purpose. (Provided we can update one day when they fix the build slowdown...)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants