Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

paper comments that should become code changes #79

Open
1 of 4 tasks
mhance opened this issue May 24, 2023 · 1 comment
Open
1 of 4 tasks

paper comments that should become code changes #79

mhance opened this issue May 24, 2023 · 1 comment

Comments

@mhance
Copy link
Contributor

mhance commented May 24, 2023

See some comments especially from Zach: scipp-atlas/mapyde-paper#11. Some of these motivate some code changes, especially the ones near the end starting at Line 413:

  • L413: Can they define multiple scripts? How? Or do they need to do this by hand (e.g. tying all their own scripts together with a top-level bash script)?

  • L420+: “This is particularly…” — can we set blocks that run both on the Pythia output and on the Delphes output in a single run?

  • L432: “The options entry…” — in the other steps where there’s a script (e.g. B.9), can I just provide options in the “script” string? Or do I have to have a separate entry, or even only use the defaults?

  • L438: You might specify that muscan.py is a script from pyhf (the pyhf script muscan.py), rather than a script that the user should write (because its name doesn’t appear in the [pyhf] block, I assume this is hard-coded?). If it’s not, then you might be clear about where this is coming from (maybe also up on L90?).

@kratsg
Copy link
Contributor

kratsg commented Jun 13, 2023

L438: You might specify that muscan.py is a script from pyhf (the pyhf script muscan.py), rather than a script that the user should write (because its name doesn’t appear in the [pyhf] block, I assume this is hard-coded?). If it’s not, then you might be clear about where this is coming from (maybe also up on L90?).

This is #86.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants