Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace _inplace_contiguous_isotonic_regression by scipy.optimize.isotonic_regression #27378

Open
lorentzenchr opened this issue Sep 15, 2023 · 0 comments · May be fixed by #28897
Open

Replace _inplace_contiguous_isotonic_regression by scipy.optimize.isotonic_regression #27378

lorentzenchr opened this issue Sep 15, 2023 · 0 comments · May be fixed by #28897
Labels
Moderate Anything that requires some knowledge of conventions and best practices module:isotonic

Comments

@lorentzenchr
Copy link
Member

With the upcomping scipy 1.12, there will be the new function scipy.optimize.isotonic_regression, see scipy/scipy#17722.

We can start using this function (which is a bit faster than our own method) and replace ours completely once scipy 1.12 is the minimum scipy version.
@github-actions github-actions bot added the Needs Triage Issue requires triage label Sep 15, 2023
@lorentzenchr lorentzenchr added module:isotonic Moderate Anything that requires some knowledge of conventions and best practices and removed Needs Triage Issue requires triage labels Sep 15, 2023
@lorentzenchr lorentzenchr linked a pull request Apr 26, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Moderate Anything that requires some knowledge of conventions and best practices module:isotonic
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ENH use Scipy isotonic_regression lorentzenchr/scikit-learn
1 participant
@lorentzenchr