Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 1.2.0rc1 #25045

Merged
merged 9 commits into from Nov 28, 2022
Merged

Release 1.2.0rc1 #25045

merged 9 commits into from Nov 28, 2022

Conversation

jeremiedbb
Copy link
Member

@jeremiedbb jeremiedbb commented Nov 25, 2022

  • update news and what's new date in release branch
  • update news and what's new date and sklearn dev0 version in main branch
  • check that the for the release wheels can be built successfully
  • merge the PR with [cd build] commit message to upload wheels to the staging repo
  • upload the wheels and source tarball to https://test.pypi.org
  • create tag on the main github repo
  • confirm bot detected at
    https://github.com/conda-forge/scikit-learn-feedstock and wait for merge
  • upload the wheels and source tarball to PyPI
  • https://github.com/scikit-learn/scikit-learn/releases publish (except for RC)
  • announce on mailing list and on Twitter, and LinkedIn
  • update SECURITY.md in main branch (except for RC)

@adrinjalali
Copy link
Member

We need to add "update SECURITY.md" on main to the list :)

@glemaitre
Copy link
Member

glemaitre commented Nov 28, 2022

We need to cherry-pick this one: #25054

@ogrisel
Copy link
Member

ogrisel commented Nov 28, 2022

We need to add "update SECURITY.md" on main to the list :)

This need to be updated in main once the 1.2.0 final is release. We don't need to do anything for the rc1 itself.

@jeremiedbb
Copy link
Member Author

I backported what's needed to be backported, and updated the docs and version. The wheel builds are all green. Let's merge

@jeremiedbb jeremiedbb merged commit c7d5f58 into scikit-learn:1.2.X Nov 28, 2022
@jeremiedbb
Copy link
Member Author

I couldn't upload the wheels on PyPI (project size limit reached, 10GB). I put it on hold, and the PR on conda-forge as well, while I'm trying to get our project size to be increased (and/or we make room by deleting some old releases)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants