CI Remove remaining windows 32 references #24657
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomasjpfan
changed the title
thomasjpfan
changed the title
thomasjpfan
changed the title
|
LGTM but while the win64 build is not fixed it's hard to be 100% sure that this PR does not introduce any regression. Maybe we should wait for a maintenance release of scipy with scipy/scipy#17224 before merging this. |
|
@thomasjpfan , I didn't check the details of this PR and I introduced the same changes in #24446 ... well, anyway, if you folks want to merge this one before, I will just merge in my branch. |
jjerphan
approved these changes
Oct 20, 2022
There was a problem hiding this comment.
LGTM!
I think this comment can be removed as well as we will from now on implicitly define 64bit configurations:
scikit-learn/.github/workflows/wheels.yml
Line 83 in 3e6a39a
jjerphan
reviewed
Oct 20, 2022
glemaitre
added
the
To backport
glemaitre
pushed a commit
to glemaitre/scikit-learn
that referenced
this pull request
Oct 26, 2022
Co-authored-by: Julien Jerphanion <git@jjerphan.xyz> Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org>
glemaitre
pushed a commit
that referenced
this pull request
Oct 26, 2022
Co-authored-by: Julien Jerphanion <git@jjerphan.xyz> Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org>
glemaitre
pushed a commit
to glemaitre/scikit-learn
that referenced
this pull request
Oct 31, 2022
Co-authored-by: Julien Jerphanion <git@jjerphan.xyz> Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Follow up to #24627
What does this implement/fix? Explain your changes.
This PR removes remaining windows 32bit code for building wheels.