DOC some more fixes for changelog preparing release 1.1.1 #23420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glemaitre
added
the
To backport
glemaitre
changed the title
glemaitre
commented
May 19, 2022
| @@ -234,17 +245,6 @@ Changelog | |||
| :func:`sklearn.set_config`. | |||
| :pr:`22856` by :user:`Jérémie du Boisberranger <jeremiedbb>`. | |||
|
|
|||
| - |Enhancement| The error message is improved when importing | |||
There was a problem hiding this comment.
I don't really understand why they appear here since they are not part of 1.1.0
There was a problem hiding this comment.
they must have been merged after I made the PR for the RC and not marked as "to backport"
glemaitre
commented
May 19, 2022
| @@ -12,6 +12,17 @@ Version 1.1.1 | |||
| Changelog | |||
| --------- | |||
|
|
|||
| - |Enhancement| The error message is improved when importing | |||
There was a problem hiding this comment.
I move them to 1.1.1 because they are not part of 1.1.0
Even if they are categorized as "Enhancement", they are more documentation and error message fixing.
I think this is fine to put them in the bugfix release.
There was a problem hiding this comment.
Well since we already advertised them in the changelog I think it's ok to include them in the bug fix release.
|
ping @jeremiedbb |
|
The rendering is fine. Let's backport once the ci build finished |
glemaitre
added a commit
to glemaitre/scikit-learn
that referenced
this pull request
May 19, 2022
glemaitre
added a commit
that referenced
this pull request
May 19, 2022
lesteve
pushed a commit
to lesteve/scikit-learn
that referenced
this pull request
May 19, 2022
mathijs02
pushed a commit
to mathijs02/scikit-learn
that referenced
this pull request
Dec 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that these entries are in 1.1.0 but I actually backported them in 1.1.1