Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC Update model persistence URL #23402

Merged
merged 1 commit into from May 18, 2022

Conversation

dpoznik
Copy link
Contributor

@dpoznik dpoznik commented May 17, 2022

This PR fixes a warning-message URL.

Before
This URL forwards to the correct page, but the fragment component of the URL is lost in the process:
https://scikit-learn.org/stable/modules/model_persistence.html#security-maintainability-limitations

After
https://scikit-learn.org/stable/model_persistence.html#security-maintainability-limitations

@thomasjpfan thomasjpfan changed the title Update model persistence URL DOC Update model persistence URL May 17, 2022
Copy link
Member

@thomasjpfan thomasjpfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR!

LGTM

@thomasjpfan thomasjpfan added this to the 1.1.1 milestone May 17, 2022
@thomasjpfan thomasjpfan added the To backport PR merged in master that need a backport to a release branch defined based on the milestone. label May 17, 2022
@ogrisel
Copy link
Member

ogrisel commented May 18, 2022

The CI error seems caused by a random infrastructure problem on Azure. Let's merge.

@ogrisel ogrisel merged commit bd196eb into scikit-learn:main May 18, 2022
glemaitre pushed a commit to glemaitre/scikit-learn that referenced this pull request May 19, 2022
glemaitre pushed a commit that referenced this pull request May 19, 2022
lesteve pushed a commit to lesteve/scikit-learn that referenced this pull request May 19, 2022
@dpoznik dpoznik deleted the update-model-persistence-url branch September 16, 2022 23:59
mathijs02 pushed a commit to mathijs02/scikit-learn that referenced this pull request Dec 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation To backport PR merged in master that need a backport to a release branch defined based on the milestone.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants