Black introduced a lot of interrupted strings

[lorentzenchr]

PR #18948 that applied black to most of the codebase introduced interrupted strings due to a longer line length:

before

raise ValueError("My message "
                  "might be long.")

after applying black

raise ValueError("My message " "might be long.")

@scikit-learn/core-devs Should we remove those " "?
@reshamas Removing those could be something for a sprint.

[reshamas]

Thanks @lorentzenchr.

@amueller @thomasjpfan
Should we add this issue to the list?

[rth]

Thanks for catching this!

I would say this can be fixed in 1 PR with a regexp and some manual checks resulting in ~300-400 LoC diff, and such PR might not be the best to start contributing. Also we would probably re-discuss the black line length in the meeting Monday, so it might be better to postpone this issue until then.

[thomasjpfan]

The following works for combining strings automatically:

black --experimental-string-processing .

For the black linter to pass, we would need to enable it by default:

[tool.black]
experimental_string_processing = true

XREF: psf/black#2188