Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MRG] FIX add pos_label when computing AP in plot_precision_recall_curve #15739

Merged
merged 3 commits into from Nov 29, 2019
Merged

[MRG] FIX add pos_label when computing AP in plot_precision_recall_curve #15739

merged 3 commits into from Nov 29, 2019

Conversation

glemaitre
Copy link
Member

closes #15738

We need to pass pos_label into average_precision_score

@glemaitre
Copy link
Member Author

No need for what's new since we introduce the function in 0.22

@glemaitre glemaitre added this to the 0.22 milestone Nov 28, 2019
@glemaitre
Copy link
Member Author

I will not be able to make any changes tomorrow. Do not hesitate to directly push any fix to be able to merge it. I think this release critical to not release the plotting with this issue.
I think that we should have a common test which are using labels string instead of simple numeric y. We should catch the pos_label error at least.

@glemaitre glemaitre changed the title FIX add pos_label when computing AP in plot_precision_recall_curve [MRG] FIX add pos_label when computing AP in plot_precision_recall_curve Nov 28, 2019
thomasjpfan
thomasjpfan approved these changes Nov 29, 2019
View reviewed changes
Copy link
Member

@thomasjpfan thomasjpfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated PR to test the average precision as well and a small refactor to define y in the test.

qinhanmin2014
qinhanmin2014 approved these changes Nov 29, 2019
View reviewed changes
Copy link
Member

@qinhanmin2014 qinhanmin2014 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@qinhanmin2014 qinhanmin2014 merged commit f4da713 into scikit-learn:master Nov 29, 2019
@glemaitre
Copy link
Member Author

Thanks guys

adrinjalali pushed a commit to adrinjalali/scikit-learn that referenced this pull request Dec 2, 2019
@glemaitre @adrinjalali
FIX add pos_label when computing AP in plot_precision_recall_curve (s…
57aa4a1 
…cikit-learn#15739)
adrinjalali pushed a commit that referenced this pull request Dec 2, 2019
@glemaitre @adrinjalali
FIX add pos_label when computing AP in plot_precision_recall_curve (#…
4246521 
…15739)
panpiort8 pushed a commit to panpiort8/scikit-learn that referenced this pull request Mar 3, 2020
@glemaitre
FIX add pos_label when computing AP in plot_precision_recall_curve (s…
9755dbb 
…cikit-learn#15739)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomasjpfan thomasjpfan thomasjpfan approved these changes

@qinhanmin2014 qinhanmin2014 qinhanmin2014 approved these changes

@NicolasHug NicolasHug Awaiting requested review from NicolasHug

@adrinjalali adrinjalali Awaiting requested review from adrinjalali

Assignees
No one assigned
Labels
Blocker
Projects
None yet
Milestone
0.22
Development

Successfully merging this pull request may close these issues.

Bug in plot_precision_recall_curve
3 participants
@glemaitre @thomasjpfan @qinhanmin2014