DOC Typo in the error message of _binary_clf_curve #15703
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We accept a float dtype, but we don't accept real numbers, right? Saying a value should be an integer is different from saying it should be of type int, so I think the current docstrings are correct. i.e. math domain != type |
|
Well @NicolasHug you can close this if you think current version is okay, but I'd argue that it's misleading. What's more, the author of the original PR has approved this PR. |
NicolasHug
reviewed
Nov 22, 2019
| @@ -539,7 +539,7 @@ def _binary_clf_curve(y_true, y_score, pos_label=None, sample_weight=None): | |||
| classes_repr = ", ".join(repr(c) for c in classes) | |||
| raise ValueError("y_true takes value in {{{classes_repr}}} and " | |||
| "pos_label is not specified: either make y_true " | |||
| "take integer value in {{0, 1}} or {{-1, 1}} or " | |||
| "take value in {{0, 1}} or {{-1, 1}} or " | |||
There was a problem hiding this comment.
sorry what do you mean?
There was a problem hiding this comment.
@NicolasHug We can't use {} here because {} has special meaning. We need to use {{}} to output {}.
|
I don't think it's misleading, but I don't mind |
|
I'm going to merge because the author of the original PR approved it, and Nicolas is not opposed to it. |
adrinjalali
pushed a commit
to adrinjalali/scikit-learn
that referenced
this pull request
Nov 27, 2019
jnothman
pushed a commit
that referenced
this pull request
Nov 28, 2019
panpiort8
pushed a commit
to panpiort8/scikit-learn
that referenced
this pull request
Mar 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Typo in #15562, we support float y_true and it's tested.
ping @ogrisel @thomasjpfan