sed executed in regexp mode. #15680
Merged
sed executed in regexp mode. #15680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Let me check locally |
|
Seems to work :) |
Yep I'm happier if you check. Thanks. |
Thank you Thomas! ;) |
Merged
adrinjalali
pushed a commit
to adrinjalali/scikit-learn
that referenced
this pull request
Nov 27, 2019
jnothman
pushed a commit
that referenced
this pull request
Nov 28, 2019
panpiort8
pushed a commit
to panpiort8/scikit-learn
that referenced
this pull request
Mar 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Should fix false positives in sphinx warning detection (see #15633 #13227)
What does this implement/fix? Explain your changes.
seduses extended regular expressions in the script (-Eoption)Note that
thumbfiles are linked inwhats_new/older_version.rstalso, so it is indeed useful to look for them.