Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark implemented SLEPS #56

Open
lorentzenchr opened this issue Aug 23, 2021 · 3 comments
Open

Mark implemented SLEPS #56

lorentzenchr opened this issue Aug 23, 2021 · 3 comments

Comments

@lorentzenchr
Copy link
Member

As of today, https://scikit-learn-enhancement-proposals.readthedocs.io/en/latest/index.html lists two SLEPs as accepted:

  • SLEP009
  • SLEP010

It is, however, not clear from the webpage if those SLEPs are implemented. I propose to link at least the scikit-learn version, maybe also relevant PRs, that implemented them.

@glemaitre
Copy link
Member

In Python, there is a "Final" status to acknowledge that the PEP is implemented. We could do something similar by listing them separately and adding the scikit-learn version where the interface is stable.

@glemaitre
Copy link
Member

I assume that it should be part of the SLEP000: https://github.com/scikit-learn/enhancement_proposals/pull/30/files

@glemaitre
Copy link
Member

Actually, this something this is mentioned here and could be improved: https://github.com/scikit-learn/enhancement_proposals/pull/30/files#r758344193

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants