Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarification of the "symmetry" argument in CQR and more general documentation about CQR #249

Closed
gmartinonQM opened this issue Jan 5, 2023 · 1 comment · Fixed by #443
Assignees
Labels
developers Proposed by developers. documentation Improvements or additions to documentation
Milestone

Comments

@gmartinonQM
Copy link
Contributor

gmartinonQM commented Jan 5, 2023

Hi all, and thanks again for all your developments of MAPIE !

I recently struggled with CQR, wondering what was the impact of the symmetry argument in MapieQuantileRegressor.predict function. The docstring is quite elusive :

"Deciding factor to whether to find the quantile value for each residuals separatly or to use the maximum of the two combined."

(BTW there is a typo on "separatly" -> "separately").

And I cannot find more information, be it in the theoretical description, the tutorial on CQR or the 1D-heteroscedastic example.

Would it be possible to better describe the impact of the argument and to illustrate it in the tutorial for example ?

Moreover, I am not sure that I understand the notations in the theoretical description. For example, there are three different notations E_i, E_{low} and E_{high} but none is defined. As for the vocabulary, I find the word "residual" confusing in the context of CQR, because it suggests that we compute the difference between the target and the main model prediction (the median estimator) whereas we compare with the other two quantiles.

Capture d’écran 2023-01-05 à 22 15 30

Would it be possible to clarify these points ?

Thanks in advance !

@gmartinonQM gmartinonQM added the documentation Improvements or additions to documentation label Jan 5, 2023
@nmdwolf
Copy link

nmdwolf commented Jan 6, 2023

The standard implementation uses the maximum of the lower and upper quantile residuals. However, one could generalize this method to correct the lower and upper quantiles independently (with some correction as to maintain the required significance level). I assume this is what they mean. (I feel like the documentation should be improved and corrected on many levels.)

@LacombeLouis LacombeLouis added this to Methods to be implemented (Short Term) in Developments via automation Feb 23, 2023
@LacombeLouis LacombeLouis moved this from Methods to be implemented (Short Term) to Bugs to be fixed (Short Term) in Developments Feb 23, 2023
@thibaultcordier thibaultcordier removed this from Bugs to be fixed (Short Term) in Developments Feb 23, 2023
@thibaultcordier thibaultcordier added this to Need triage in Developments via automation Feb 23, 2023
@thibaultcordier thibaultcordier moved this from Need triage to Bugs to be fixed (Short Term) in Developments Feb 23, 2023
@thibaultcordier thibaultcordier added the developers Proposed by developers. label Jul 4, 2023
@LacombeLouis LacombeLouis added this to the Backlog H2 milestone Aug 3, 2023
@LacombeLouis LacombeLouis added this to H2 2023 in Roadmap Aug 3, 2023
@LacombeLouis LacombeLouis modified the milestones: Backlog H2 2023, Release 0.8.0 Aug 3, 2023
@LacombeLouis LacombeLouis moved this from H2 2023 to H1 2024 in Roadmap Jan 3, 2024
@LacombeLouis LacombeLouis modified the milestones: Release 0.8.0, 0.9.0 Apr 25, 2024
Developments automation moved this from Bugs to be fixed (High Priority) to Done May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
developers Proposed by developers. documentation Improvements or additions to documentation
Projects
Roadmap
H1 2024
4 participants