Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use the Codecov CLI to upload coverage #2256

Open
1 task done
matthewfeickert opened this issue Jul 20, 2023 · 1 comment · May be fixed by #2260
Open
1 task done

Use the Codecov CLI to upload coverage #2256

matthewfeickert opened this issue Jul 20, 2023 · 1 comment · May be fixed by #2260
Assignees
@matthewfeickert
Labels
feat/enhancement New feature or request tests pytest

Comments

@matthewfeickert
Copy link
Member

matthewfeickert commented Jul 20, 2023 •
edited

Summary

To potentially use Sentry's/Codecov's ATS we first need to use the Codecov CLI to upload our coverage reports.

https://docs.codecov.com/docs/the-codecov-cli#how-to-upload-to-codecov makes it seem like the workflow would be

$ python -m pip install --upgrade codecov-cli
$ codecovcli create-commit
$ codecovcli create-report
$ codecovcli do-upload

though I'm not sure how to replace all the options we use with the codecov-action

pyhf/.github/workflows/ci.yml

Lines 64 to 72 in fb604e8

# Report coverage for oldest and newest Python tested to deal with version differences
- name: Report core project coverage with Codecov
if: >-
github.event_name != 'schedule' &&
matrix.os == 'ubuntu-latest'
uses: codecov/codecov-action@v3
with:
files: ./coverage.xml
flags: unittests-${{ matrix.python-version }}

Additional Information

CLI Options: https://docs.codecov.com/docs/cli-options

Code of Conduct

  • I agree to follow the Code of Conduct
@matthewfeickert matthewfeickert added feat/enhancement New feature or request tests pytest labels Jul 20, 2023
@matthewfeickert matthewfeickert self-assigned this Jul 20, 2023
@matthewfeickert
Copy link
Member Author

Given https://docs.codecov.com/docs/cli-options this might be doable with just

$ python -m pip install --upgrade codecov-cli
$ codecovcli create-commit
$ codecovcli create-report
$ codecovcli do-upload --file ./coverage.xml --flag unittests-${{ matrix.python-version }}

@matthewfeickert matthewfeickert linked a pull request Jul 20, 2023 that will close this issue
Draft
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@matthewfeickert matthewfeickert

Labels
feat/enhancement New feature or request tests pytest
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ci: Use codecov-cli for coverage report upload scikit-hep/pyhf
1 participant
@matthewfeickert