Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update validator for jsonschema #1980

Open
matthewfeickert opened this issue Sep 2, 2022 · 1 comment · May be fixed by #1978
Open

Update validator for jsonschema #1980

matthewfeickert opened this issue Sep 2, 2022 · 1 comment · May be fixed by #1978
Assignees
Labels
schema and spec JSON schema

Comments

@matthewfeickert
Copy link
Member

It seems that the issue is because of the fact that in the custom schema, we have

{
    "$schema": "http://json-schema.org/draft-06/schema#",
    "$id": "1.1.0/workspace.json",
    "$ref": "defs.json#/definitions/workspace"
}

which is set with base_uri = path/to/custom_schemas/1.1.0 in #1976 . Since there's a $ref and an $id - the $id is being used to add a 1.1.0 to the base_uri when it shouldn't be. So yes, this is a bug in jsonschema that was resolved in 4.15.0.

We could update this to a newer draft for the validator, and this issue won't occur.

Originally posted by @kratsg in #1979 (comment)

@matthewfeickert matthewfeickert added schema and spec JSON schema needs-triage Needs a maintainer to categorize and assign labels Sep 2, 2022
@kratsg
Copy link
Contributor

kratsg commented Sep 2, 2022

This is #1978

@matthewfeickert matthewfeickert removed the needs-triage Needs a maintainer to categorize and assign label Sep 2, 2022
@matthewfeickert matthewfeickert linked a pull request Sep 2, 2022 that will close this issue
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
schema and spec JSON schema
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants